fix: roll back to uglify-es 3.2.2 #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably worth trying babel-minify, BTW. |
|
Nice find! 🕵️♂️ |
Closed
|
@saschanaz, will babel-minify allow us to get rid of the dependency on uglify? I guess we would only run it when we generate the packaged version. |
|
Yes, we won't have to call babel and then uglify, we can just call babel-minify and that's it. |
marcoscaceres
added a commit
that referenced
this pull request
Feb 5, 2018
* develop: v19.1.0 chore(package): use uglify-es 3.3.7 (#1474) feat(webidl): support interface mixins (#1468) refactor: Migrate to ES2017 async functions (#1471) Fix(w3c/headers): typo (#1472) chore: update webidl2.js to version 10.2.0 (#1465) workaround: add git commit hash (#1464) fix: nightmare api usage (#1460) New link to the Process 2018 (#1466) fix: roll back to uglify-es 3.2.2 (#1461)
|
Ok, but it would be a hard requirement that we can generate a concatenated, but not minified, version for development... otherwise, debugging is going to be extremely hard. Sourcemaps are very very broken across browsers, so definitely don't want to be reliant on them (been there, done that, never again 🤪). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1458
It turns out that the recent update of uglify-es is the culprit.
(This includes #1459 so you will probably want to merge it first)