Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permalinks are not attached to divs #315

Closed
halindrome opened this issue Jun 9, 2014 · 2 comments · Fixed by #320
Closed

permalinks are not attached to divs #315

halindrome opened this issue Jun 9, 2014 · 2 comments · Fixed by #320

Comments

@halindrome
Copy link
Contributor

The permalink feature should work not just when there is a heading as an immediate child of a section element, but also when there is a heading as an immediate child of a div element.
@darobin
Copy link
Member

darobin commented Jun 10, 2014

On 09/06/2014 23:06 , Shane McCarron wrote:

The permalink feature should work not just when there is a heading as an
immediate child of a section element, but also when there is a heading
as an immediate child of a div element.

Why would there be a heading on anything other than a section?

@halindrome
Copy link
Contributor Author

Well - two reasons I can think of.

First, in the ARIA 1.1 spec, there are about 100 "sections" where we are not using the section element because we do not want section numbers and you said we should not add the ability to disable those.

Second, there are "notes" sometimes that have headings within a spec. Editorial notes or other such notes. I don't know that those should have permalinks, but I imagine they should have the option.

halindrome added a commit to halindrome/respec that referenced this issue Jun 19, 2014
@halindrome
Ensured that headings inside divs get permalinks
4912932 
In the ARIA spec there are many headings that are not part of a
section because they do not want section numbers, but they DO want
permalinks.  Allow permalinks on headers that are within a div where
the div or the header has an ID.
Fixes w3c#315.
@halindrome halindrome mentioned this issue Jun 19, 2014
Merged
shikhar-scs pushed a commit to shikhar-scs/respec that referenced this issue Feb 19, 2018
@almossawi
Merge pull request w3c#315 from dandehavilland/travis-setup
50eeb6c 
travis-ci setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding permalinks to h* within div halindrome/respec
2 participants
@darobin @halindrome