Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/inlines could use Ranges #378

Closed
darobin opened this issue Dec 18, 2014 · 1 comment
Closed

core/inlines could use Ranges #378

darobin opened this issue Dec 18, 2014 · 1 comment

Comments

@darobin
Copy link
Member

darobin commented Dec 18, 2014

It wasn't an option when the original code was written because Range support was too flimsy, but it is much better now. I think that instead of doing what it is doing now which involves creating a DocumentFragment for all matching Text nodes, building the content inside, and replacing the Text node in its parent (which I'm guessing isn't fast) we could likely use surroundContents() instead. Low priority but worth investigating.

@marcoscaceres
Copy link
Member

I looked into this a bit... I'm not convinced. Using DocumentFragment is fine.

shikhar-scs pushed a commit to shikhar-scs/respec that referenced this issue Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants