Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run respec2html.js was part of the test suite. #501

Closed
marcoscaceres opened this issue Sep 14, 2015 · 2 comments
Closed

Run respec2html.js was part of the test suite. #501

marcoscaceres opened this issue Sep 14, 2015 · 2 comments
Milestone

Comments

@marcoscaceres
Copy link
Member

@marcoscaceres keeps breaking respec2html.js because it's not tested as part of the our test suite. We should either ban Marcos or fix the test suite.

@marcoscaceres
Copy link
Member Author

@dontcallmedom thoughts on how we do this... I don't have any direct experience with respec2html.js.

@marcoscaceres marcoscaceres added this to the 3.2 milestone Sep 14, 2015
@dontcallmedom
Copy link
Member

my suggestion (and sorry I can't afford to provide a patch for this at the moment):

  • prepare a set of respec-valid documents that loads respec from within the repo; ideally, they would exercise as much of respec as possible (e.g. a bunch of webidl)
  • add to the "test" script in package.json a rule to run "./tools/respec2html.js -e -w " on these documents
  • a bonus point might to be to run an HTML5 validator on the output of that command — that way, we would detect when respec starts generating invalid HTML5; this might be better done in Travis CI though (see how I do it e.g. for the WebRTC spec)

(I don't know if the stuff in tests/specifications was supposed to be used for this kind of test? maybe that wouldn't be a bad place to put these new "respec-valid" documents)

dontcallmedom added a commit to dontcallmedom/respec that referenced this issue Jan 11, 2016
dontcallmedom added a commit to dontcallmedom/respec that referenced this issue Jan 12, 2016
shikhar-scs pushed a commit to shikhar-scs/respec that referenced this issue Feb 19, 2018
Fix documentation to add the 'mg-' class prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants