Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Karma instead of Phantomjs #572

Closed
marcoscaceres opened this issue Feb 24, 2016 · 1 comment
Closed

Use Karma instead of Phantomjs #572

marcoscaceres opened this issue Feb 24, 2016 · 1 comment
Assignees
@marcoscaceres
Labels
refactoring
Milestone
3.2

Comments

@marcoscaceres
Copy link
Member

It seems pointless to use Phantomjs for anything other than the spec generator. Phantomjs is constantly out of date, doesn't support any new shinny, and it is generally a piece of crap to work with and debug.

Karma uses actual browsers and works with Travis. Thus, we should retire our use of Phantom and move to using Karma and never look back.
@tripu
Copy link
Member

tripu commented Feb 26, 2016

(I take note of the idea, thinking of other projects we have using PhantomJS!)

@marcoscaceres marcoscaceres self-assigned this Feb 27, 2016
@marcoscaceres marcoscaceres added this to the 3.2 milestone Feb 27, 2016
marcoscaceres added a commit that referenced this issue Mar 1, 2016
@marcoscaceres
Using Karma instead of phantom.js (closes #572)
10bb345 
 * Add support for Karma + configuration
 * Add test driver for Karma
 * Add new + update dependencies for Karma support
 * Deleted console-runner.js, using Karma instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoscaceres marcoscaceres

Labels
refactoring
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
2 participants
@marcoscaceres @tripu