Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Edge due to use of ES7 "includes" method #720

Closed
tidoust opened this issue Apr 28, 2016 · 1 comment
Closed

Crash on Edge due to use of ES7 "includes" method #720

tidoust opened this issue Apr 28, 2016 · 1 comment
Labels

Comments

@tidoust
Copy link
Member

tidoust commented Apr 28, 2016

Latest version of ReSpec crashes on Edge while building the list of references with the following error:

TypeError: Object doesn't support property or method 'includes'
   at Anonymous function (https://www.w3.org/Tools/respec/respec-w3c-common:16:2376)
   at Array.prototype.reduce (native code)
   at run (https://www.w3.org/Tools/respec/respec-w3c-common:16:2229)
   at Anonymous function (https://www.w3.org/Tools/respec/respec-w3c-common:10:23241)
   at Promise (native code)
   at Anonymous function (https://www.w3.org/Tools/respec/respec-w3c-common:10:23202)

Problem is Array.prototype.includes is not yet supported in MS Edge.

The function got introduced last week in js/core/biblio.js:
92f8954

(I haven't tested, but I see that it also appears in test/test-build.js where it would probably crash as well)

@tidoust tidoust added the bug label Apr 28, 2016
@marcoscaceres marcoscaceres changed the title Crash on Edge due to use of ES6 "includes" method Crash on Edge due to use of ES7 "includes" method May 2, 2016
@marcoscaceres
Copy link
Member

Fix released in 3.2.121

shikhar-scs pushed a commit to shikhar-scs/respec that referenced this issue Feb 19, 2018
Allow markers to be on the edge of the graph.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants