Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dfn + code chops off space #783

Closed
marcoscaceres opened this issue May 24, 2016 · 9 comments
Closed

dfn + code chops off space #783

marcoscaceres opened this issue May 24, 2016 · 9 comments
Labels
bug

Comments

@marcoscaceres
Copy link
Member

marcoscaceres commented May 24, 2016 •
edited

This code:

For clarity, a <dfn>megabit</dfn> is 1,000,000 bits, and 
<dfn data-lt="Mbit/s">megabits per second</dfn> is equivalent to transferring:

Turns into:
screenshot 2016-05-24 17 30 52

Which is missing the space between "megabits" and "is".
@marcoscaceres
Copy link
Member Author

Also happening with following markdown:

  1. <a>Fire a simple event</a> named `change` at the `NetworkInformation` object.

@halindrome
Copy link
Contributor

Interesting - is this happening ONLY in markdown?

@marcoscaceres
Copy link
Member Author

I think so. See http://wicg.github.io/netinfo/

On 25 May 2016, at 12:59 AM, Shane McCarron notifications@github.com wrote:

Interesting - is this happening ONLY in markdown?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@igrigorik
Copy link
Member

This may belong in a separate bug, but I'm seeing extra spaces too..

e.g. from: http://igrigorik.github.io/feature-policy/
image

Note the extra space after the first quote.

@marcoscaceres
Copy link
Member Author

@igrigorik, fixed the other issues locally... PR incoming. Looking into the extra space issues now.

@marcoscaceres
Copy link
Member Author

@igrigorik, it appears to be a bug in the beautifier we are using, I filed a bug on them. Will try to see if I can work around it.

marcoscaceres added a commit that referenced this issue May 25, 2016
@marcoscaceres
Fix(utils): links space getting chopped off (closes #783)
e41e485
@marcoscaceres
Copy link
Member Author

@halindrome I sent a PR, could you kindly review? (or @igrigorik, if you are feeling up to it, ptal)

If it's ok, I'll get this out ASAP.

marcoscaceres added a commit that referenced this issue May 25, 2016
@marcoscaceres
Merge branch 'develop' into gh-pages
1a298e0 
* develop:
  v3.2.126
  Fix(markdown): don't add space after quot char
  Fix(utils): links space getting chopped off (closes #783)
  chore(package): update mocha to version 2.5.3
  Fix(inlines-spec.js): use spaces, not tabs
  Feat(global): implement proper PubSubHub
  Chore(package): update dependencies
@marcoscaceres
Copy link
Member Author

@dontcallmedom jumped in and did the review! He is a hero 🏆 .

@igrigorik
Copy link
Member

\o/

marcoscaceres added a commit that referenced this issue May 26, 2016
@marcoscaceres
Merge branch 'develop' into gh-pages
3fd145a 
* develop:
  v3.2.127
  Chore(release): improve error reporting
  Fix(release): stop producing versioned files (closes #780)
  Fix(markdown): Space before quote (closes #786)
  v3.2.126
  Fix(markdown): don't add space after quot char
  Fix(utils): links space getting chopped off (closes #783)
  chore(package): update mocha to version 2.5.3
  Fix(inlines-spec.js): use spaces, not tabs
  Feat(global): implement proper PubSubHub
  Chore(package): update dependencies
@snyk-bot snyk-bot mentioned this issue Apr 1, 2021
Open
@snyk-bot snyk-bot mentioned this issue Aug 22, 2021
Open
@Bhanditz Bhanditz mentioned this issue Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@igrigorik @halindrome @marcoscaceres