Add missing aria-spec

[marcoscaceres]

Missing aria-spec.js in tests means that aria stuff is tested in all sorts of wrong places.

[marcoscaceres]

e.g., in structure-spec.js

expect(toc.querySelector("ol:first-of-type").getAttribute("role")).toEqual("directory");

[halindrome]

I don't disagree. Although @ROLE is not just an ARIA thing, fwiw.

On Thu, Aug 4, 2016 at 5:15 AM, Marcos Cáceres notifications@github.com
wrote:

e.g.,

expect(toc.querySelector("ol:first-of-type").getAttribute("role")).toEqual("directory");

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#906 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfx8KzIl3zoXbqoIcl2kd1HFXdXfsc5ks5qcbvNgaJpZM4JcjJ6
.

Shane McCarron
halindrome@gmail.com

[marcoscaceres]

The problem is that it is not structure.js that sets role: it is aria.js. As I was refactoring the tests, that confused me. So, it's just about making sure that we test only the functionality of a module.

On 5 Aug 2016, at 5:01 AM, Shane McCarron notifications@github.com wrote:

I don't disagree. Although @ROLE is not just an ARIA thing, fwiw.

On Thu, Aug 4, 2016 at 5:15 AM, Marcos Cáceres notifications@github.com
wrote:

e.g.,

expect(toc.querySelector("ol:first-of-type").getAttribute("role")).toEqual("directory");

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#906 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfx8KzIl3zoXbqoIcl2kd1HFXdXfsc5ks5qcbvNgaJpZM4JcjJ6
.

Shane McCarron
halindrome@gmail.com
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[halindrome]

Good point. That is my stupidity i fear.

On Aug 4, 2016 5:00 PM, "Marcos Cáceres" notifications@github.com wrote:

The problem is that it is not structure.js that sets role: it is aria.js.
As I was refactoring the tests, that confused me. So, it's just about
making sure that we test only the functionality of a module.

On 5 Aug 2016, at 5:01 AM, Shane McCarron notifications@github.com
wrote:

I don't disagree. Although @ROLE is not just an ARIA thing, fwiw.

On Thu, Aug 4, 2016 at 5:15 AM, Marcos Cáceres <notifications@github.com

wrote:

e.g.,

expect(toc.querySelector("ol:first-of-type").getAttribute("
role")).toEqual("directory");

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#906 (comment), or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/
AAfx8KzIl3zoXbqoIcl2kd1HFXdXfsc5ks5qcbvNgaJpZM4JcjJ6>
.

Shane McCarron
halindrome@gmail.com
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#906 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfx8FdT4LyUuevy8Glz4KQPIhSlf5h6ks5qcmDdgaJpZM4JcjJ6
.

[marcoscaceres]

This is no longer valid.