Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intl human date #1139

Merged
merged 2 commits into from Mar 8, 2017
Merged

Intl human date #1139

merged 2 commits into from Mar 8, 2017

Conversation

marcoscaceres
Copy link
Member

No description provided.

marcoscaceres
marcoscaceres commented Mar 8, 2017
View reviewed changes
tests/spec/core/utils-spec.js
d.setDate(15);
expect(utils.humanDate(d)).toEqual("15 March 1977");
expect(utils.humanDate(d, "en")).toEqual("15 March 1977");
expect(utils.humanDate(d, "nl")).toEqual("15 maart 1977");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhvenema, is it convention in dutch to have months in lowercase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, according to grammar, it ougth to be lowercase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhvenema, awesome, thanks for confirming!

@marcoscaceres marcoscaceres merged commit fd82267 into develop Mar 8, 2017
@marcoscaceres marcoscaceres deleted the intl_human_date branch March 8, 2017 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhvenema dhvenema dhvenema left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcoscaceres @dhvenema