New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds "preview" status, for @tobie previews #1334
Conversation
marcoscaceres
commented
Jul 26, 2017
- makes specs unofficial when previewing
4ef28f1
to
33fa0ef
Compare
@tobie, this now will set things to unofficial and add a warning if the spec status is "unofficial". When you generate the spec, can you please add |
33fa0ef
to
a90a5d1
Compare
Might also be worth adding a link back to the PR, etc. |
OK, shipped and deployed this. LMK how it goes? |
Oh, wait! Do you want |
specStatus=preview |
Fixed. |
This seems to be breaking specs which now reference missing resources on w3.org, e.g.: https://s3.amazonaws.com/pr-preview/w3c/webrtc-pc/issue-1470-patch.html |
@tobie thanks for trying it out. Upon reflection, I think what I actually want here is only to signal that it's a preview ( It occurred to me me that Keeping the spec status is useful for checking snapshots against PubRules etc. I'll update the PR and ping you to change things again on your side (to append |
Added |
@tobie, I'll implement the branch thing separately. Might need to chat to you about it in IRC. There are a few things that could work, like:
Then I can key off |
I was mostly just thinking about having a link back to the PR. Useful in case you land on it and want the broader context and/or the merge status. |
You can get that easily from the config object: {
"params": {
"prUrl": "{{ pull_request.html_url }}",
"prNumber": "{{ pull_request.number }}"
}
} So it's trivial to add them to extra/default params in the URL. |
oh, nice! Ok, would need to add those to ReSpec - but would be trivial. |
Well, LMK which ones you'll need. :) |
@tobie will do! Will try to hack on it next week. |