Remove special chars #1387
Merged
Remove special chars #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcoscaceres
commented
Oct 6, 2017
marcoscaceres
commented
- closes Parentheses in IDs #1353
Closed
|
I only glanced through the changes, but it looks like it only special-cases parenthesis, where I think it would make more sense to only keep alphanumeric characters plus a few punctuations. If not, we should at least further special-case " since that created validity bugs |
|
Good point. I’ll restrict to ascii and just lower-case everything. |
|
I added some error recovery to lessen the impact a bit. Legacy fragments generated by ReSpec get converted to the new format. Custom ones that an author might have included (e.g., |
marcoscaceres
force-pushed
the
remove_special_chars
branch
from
6f4ebc0
to
4479771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.