Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: apply spaced-comment eslint rule #2080

Merged
merged 3 commits into from Feb 7, 2019
Merged

style: apply spaced-comment eslint rule #2080

merged 3 commits into from Feb 7, 2019

Conversation

saschanaz
Copy link
Member

This forces spaces after //, /* and before */.

@saschanaz
Copy link
Member Author

BTW is anyone using jshint here? @marcoscaceres @sidvishnoi

@marcoscaceres
Copy link
Member

Not anymore.

@saschanaz
Copy link
Member Author

Can /* jshint */ comments be removed now then?

@marcoscaceres
Copy link
Member

Yep, feel fre to remove.

@saschanaz saschanaz merged commit af2e198 into develop Feb 7, 2019
@saschanaz saschanaz deleted the spaced-comment branch February 7, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschanaz @marcoscaceres