Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/link-to-dfn): don't xref autofills (again) #2164

Merged
merged 2 commits into from Mar 18, 2019
Merged

fix(core/link-to-dfn): don't xref autofills (again) #2164

merged 2 commits into from Mar 18, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Mar 18, 2019 •
edited

What's better here is:

  1. more clear...
  2. avoid call to .closest()

saschanaz
saschanaz reviewed Mar 18, 2019
View reviewed changes
src/core/link-to-dfn.js Outdated Show resolved Hide resolved
saschanaz
saschanaz approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question.

@marcoscaceres marcoscaceres merged commit 2123f12 into develop Mar 18, 2019
@marcoscaceres marcoscaceres deleted the fix_link branch March 18, 2019 09:01
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@Bhanditz Bhanditz mentioned this pull request May 10, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcoscaceres @saschanaz