Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/inlines): add new syntax for inline <var> #2175

Merged
merged 8 commits into from Mar 23, 2019
Merged

feat(core/inlines): add new syntax for inline <var> #2175

merged 8 commits into from Mar 23, 2019

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Mar 21, 2019 •
edited 

|varName: type|     <=>    <var data-type="type">varName</var>
|varName|           <=>    <var>varName</var>

marcoscaceres
marcoscaceres reviewed Mar 21, 2019
View reviewed changes
src/core/inlines.js Outdated Show resolved Hide resolved
marcoscaceres
marcoscaceres approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Excited to use it!

saschanaz
saschanaz reviewed Mar 21, 2019
View reviewed changes
src/core/inlines.js Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi commented Mar 21, 2019
View reviewed changes
src/core/inlines.js Outdated Show resolved Hide resolved
@sidvishnoi
Copy link
Member Author

sidvishnoi commented Mar 21, 2019 •
edited

Improved regex to match following cases (suggestions welcome):

saschanaz
saschanaz reviewed Mar 22, 2019
View reviewed changes
src/core/inlines.js Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi commented Mar 22, 2019
View reviewed changes
src/core/inlines.js Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member

@saschanaz, you happy for us to go with this?

saschanaz
saschanaz approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

saschanaz
saschanaz reviewed Mar 23, 2019
View reviewed changes
src/core/inlines.js Outdated Show resolved Hide resolved
@marcoscaceres marcoscaceres merged commit 6981051 into develop Mar 23, 2019
@marcoscaceres marcoscaceres deleted the inline-var branch March 23, 2019 02:55
marcoscaceres added a commit that referenced this pull request Mar 23, 2019
@marcoscaceres
Merge branch 'develop' into gh-pages
06bbca2 
* develop:
  v24.6.0
  feat(core/inlines): add new syntax for inline <var> (#2175)
@saschanaz saschanaz mentioned this pull request Apr 22, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@Bhanditz Bhanditz mentioned this pull request May 10, 2023
Open
@Bhanditz Bhanditz mentioned this pull request Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@saschanaz saschanaz saschanaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sidvishnoi @marcoscaceres @saschanaz