Rely on a calls to an API for spec references rather than bundling the whole ref file. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
❤️ it ! :) |
|
oh, and add me as a collaborator on the other project! |
darobin
added a commit
that referenced
this pull request
May 21, 2013
Rely on a calls to an API for spec references rather than bundling the whole ref file.
|
Wonderful, thanks a lot! |
|
Ok, I can't reopen this PR because the commits were actually included before being reverted. But it should be reopened! The problem was: this doesn't work in built versions. I need to investigate why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes a number of things.
First, it modifies the codebase to rely on the specref API. The main benefit of this change is that it frees the respec project from being redeployed each time a reference is modified or added. The specref API uses continuous integration testing to verify the integrity of the database after a change and automatically redeploys without the need for manual intervention.
Secondly, it removes the reference database from the repository.
Thirdly, and that might be slightly more controversial, it removes the
previousVersionssupport for local entries. The specref API handles the expansion of those at the API level (e.g. for DAHUT-TEST5) and I thought the use case at the local entries level wasn't that compelling. (Also, I kind of found out about it after having teared it away from the code base and got lazy). @marcoscaceres: I'd love your feedback on this. I can always add it back in if you think there's value to it.