Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core/inlines): refactor inline-idl-parser #2256

Merged
merged 4 commits into from Apr 13, 2019

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 13, 2019

Demo (Input, Output, Output HTML)
<p>
  <code>
    <a data-xref-type="_IDL_" data-type="interface" href="https://dom.spec.whatwg.org/#element">Element</a>
  </code>
</p>
<p>
  <code>
    <a data-xref-type="_IDL_" data-type="interface" href="https://dom.spec.whatwg.org/#event">Event</a
    >.<a data-xref-type="attribute|dict-member" data-link-for="Event" data-type="attribute" href="https://dom.spec.whatwg.org/#dom-event-target">target</a>
  </code>
</p>
<p>
  <code>
    <a data-xref-type="_IDL_" data-type="dictionary" href="https://dom.spec.whatwg.org/#dictdef-mutationobserverinit">MutationObserverInit</a
    >.<a data-xref-type="attribute|dict-member" data-link-for="MutationObserverInit" data-type="dict-member" href="https://dom.spec.whatwg.org/#dom-mutationobserverinit-attributeoldvalue">attributeOldValue</a>
  </code>
</p>
<p>
  <code>
    <a data-xref-type="_IDL_" data-type="interface" href="https://webbluetoothcg.github.io/web-bluetooth/#bluetoothremotegattserver">BluetoothRemoteGATTServer</a
    >.[[<a data-xref-type="attribute" data-link-for="BluetoothRemoteGATTServer" data-lt="[[activeAlgorithms]]" data-type="attribute" href="https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattserver-activealgorithms-slot">activeAlgorithms</a
    >]]</code>
</p>
<p>
  <code>
    <a data-xref-type="method" data-lt="addEventListener(type, callback, options)" data-type="method" href="https://dom.spec.whatwg.org/#dom-eventtarget-addeventlistener"
      >addEventListener</a
    >(<var>type</var>, <var>callback</var>, <var>options</var>)</code>
</p>
<p>
  <code>
    <a data-xref-type="_IDL_" data-type="interface" href="https://dom.spec.whatwg.org/#eventtarget">EventTarget</a
    >.<a data-xref-type="method" data-link-for="EventTarget" data-lt="addEventListener(type, callback, options)" data-type="method"  href="https://dom.spec.whatwg.org/#dom-eventtarget-addeventlistener"  >addEventListener</a
    >(<var>type</var>, <var>callback</var>, <var>options</var>)</code>
</p>
<p>
  <code>
    <a data-xref-type="_IDL_" data-type="dictionary" href="https://encoding.spec.whatwg.org/#textdecoderoptions">TextDecoderOptions</a
    >.<a data-xref-type="attribute|dict-member" data-link-for="TextDecoderOptions" data-type="dict-member"  href="https://encoding.spec.whatwg.org/#dom-textdecoderoptions-fatal">fatal</a>
  </code>
</p>

- Remove special syntax for dict-member
- Treat attribute and dict-member same way
- Borrow inline-idl-parser from #1848
- Update tests
@marcoscaceres
Copy link
Member

We should actually bring back this:
6e4e99d

(whatever commit introduced that stuff the I stupidly removed)

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods!

@sidvishnoi sidvishnoi merged commit 10d0667 into develop Apr 13, 2019
@sidvishnoi sidvishnoi deleted the inline-idl-parser branch April 13, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants