Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when respec is referenced using https #230

Merged
merged 1 commit into from Jun 5, 2013

Conversation

cconcolato
Copy link
Collaborator

No description provided.

@tobie
Copy link
Member

tobie commented Jun 5, 2013

This is breaking the build. Not sure why.

You might want to give //specref.jit.su/bibrefs?... a try instead.

@cconcolato
Copy link
Collaborator Author

Sorry, I could not test the build. I couldn't find the documentation...
It is strange though that it doesn't work, the file header says "respecConfig" is a global variable. Maybe it is unassigned at that time.
Using // could work, but I've been told it does not work with "file:" so I wouldn't be able to test locally.

@cconcolato
Copy link
Collaborator Author

Ok I just discovered Travis-CI for respec: https://travis-ci.org/darobin/respec
I don't understand the errors though...

@tobie
Copy link
Member

tobie commented Jun 5, 2013

Yup, looks like I need to fix the test runner.

@darobin
Copy link
Member

darobin commented Jun 5, 2013

respecConfig is global as an external interface, i.e. the page that is including ReSpec can modify it multiple times (since that can be convenient) and expect reasonable results. But inside the code, there's no need to use it as each plugin gets a conf object passed in.

That said, I don't think that that's the issue that's breaking the build. Let me dig further.

darobin added a commit that referenced this pull request Jun 5, 2013
fix bug when respec is referenced using https
@darobin darobin merged commit c01fd1f into w3c:develop Jun 5, 2013
@darobin
Copy link
Member

darobin commented Jun 5, 2013

@cconcolato didn't break the build, I did!

@darobin
Copy link
Member

darobin commented Jun 5, 2013

For future reference, I found what the bug was.

conf.scheme reflects the currently used scheme. That's useful in some cases, but not when trying to reference something on the Web in an HTTPS-friendly manner. When running in many cases, it'll be fine, but for instance the test suite exercises more exotic situations and those break.

conf.httpScheme will give you https if on https, and http otherwise. That's the one to use. (Fix applied and shipped)

Thanks!

shikhar-scs pushed a commit to shikhar-scs/respec that referenced this pull request Feb 19, 2018
Fixes w3c#229: Removing area when switching between single- and multi-line chart data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants