Develop #243
Develop #243
Conversation
by default. Ensured that the output is consistent with microformats too. Incorporated the w3p vocabulary for w3c process stages. Added tests about what is generated and what is not depending on doRDFa settings. Updated documentation. Expanded generation of output documents to include XHTML1 and XHTML5. XHTML1 generation remains valid by removing aria stuff as well as HTML5 stuff.
Now supports RDFa as a default. Can be disabled with doRDFa = false. Documentation updated.
|
At a quick look this looks good, thanks, but it doesn't apply cleanly. Can you update your fork, fix the conflicts, and repush please? (It should automatically add to this PR if you push to the same origin branch.) Thanks! |
|
Well rats. Sure - might take me a little while. |
|
Thanks, this now applies cleanly, but unfortunately it breaks the build :( See https://travis-ci.org/darobin/respec/builds/8888865 for details. It seems that your test for the new ISODate is making assumptions about the default behaviour of Date objects in browsers that may differ depending on the environment. The other tests I can't really tell why they're failing just by scanning them, but I note that you explicitly disabled RDFa in some of the other tests. I'm guessing that's to make them pass because they were checking things that were interfering? |
|
Thanks I will look at that right now. Rats. |
|
Okay I made some changes... unfortunately I can't get the command line tests to actually run so I can't test the way you did. |
|
@halindrome provided you have phantomjs installed, running the tests should be as simple as running |
|
Also, the tests should run the same way as they do in the browser (more specifically, in WebKit). Thanks, I'll check later. |
| , isoDate: function (date) { | ||
| if (!(date instanceof Date)) date = this.parseSimpleDate(date); | ||
| // return "" + date.getUTCFullYear() +'-'+ this.lead0(date.getUTCMonth() + 1)+'-' + this.lead0(date.getUTCDate()) +'T'+this.lead0(date.getUTCHours())+':'+this.lead0(date.getUTCMinutes()) +":"+this.lead0(date.getUTCSeconds())+'+0000'; | ||
| return date.toISOString ; |
There was a problem hiding this comment.
Looks like you're returning the function rather than the result of applying the function here.
There was a problem hiding this comment.
You are right - weird that the test passed. Fixed.
|
Thanks for all the comments. I will effect repairs. |
|
Sounds like you're now passing the test suite. :) LGTM. |
|
Actually I had forgotten to integrate the rdfa tests into the phantom On Fri, Jul 12, 2013 at 12:59 PM, Tobie Langel notifications@github.comwrote:
Shane McCarron |
|
Thanks a lot! I'll issue a build later today, tomorrow at the latest. (After that I'm on vacation so don't expect other builds until August, unless @tobie or @dontcallmedom remember how to do them :). |
I don't. |
|
The build has shipped; I've added instructions in the readme should you need them while I'm away. I believe there's a remanent failure in the code that tests the ISO date thing. It can run afoul of local to UTC conversions, so that the test may return a different day than that which it expects :) |
Vertical bars
This pull rolls up all the necessary changes to support RDFa 1.1 by default for document generation.
Tests have been introduced and pass. They are (somewhat) comprehensive.
This is my first pull - please be gentle.