Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/link-to-dfn): use data-dfn-type in linking #2873

Merged
merged 10 commits into from May 19, 2020

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented May 15, 2020

In future, we will support more data-dfn-type/data-link-type values, like Bikeshed. Presently, only idl and dfn are supported.

In future, we will support more data-[dfn|link]-type values, like Bikeshed
@sidvishnoi sidvishnoi changed the title feat(core/link-to-dfn): distinguish between data-dfn-type feat(core/link-to-dfn): use data-dfn-type in linking May 15, 2020
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@sidvishnoi sidvishnoi merged commit 3185559 into develop May 19, 2020
@sidvishnoi sidvishnoi deleted the distinguish-dfn|link-type branch May 19, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants