Add support for Promise<> by having a general parameterized support. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mounirlamouri, this is indeed needed, but it sets the test suite on fire! See https://travis-ci.org/darobin/respec/builds/21198150 I suspect that most of these are harmless, but can you look into them please? You can run the TS on the CLI with |
|
@darobin, could you take a look at the updated commit? The tests are passing locally so I am hopeful :) |
darobin
added a commit
that referenced
this pull request
Apr 9, 2014
Add support for Promise<> by having a general parameterized support.
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't able to check the results of the tests, I mean, I know they are failing but I have no idea why.