More accessible luminosity contrast on colour for <code> #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#ff4500 has luminosity contrast of 3.4:1. Need at least 4.5:1. Use #dc3b00.
#DC3B00 provides contrast of 4.5:1 on white. But to provide a little flexibility, e.g. in the case that some <code> is in a <th> with background #eee, a colour of #C83500 provides 4.56:1 contrast, while still standing out as red text.
darobin
added a commit
that referenced
this pull request
Jul 3, 2014
More accessible luminosity contrast on colour for <code>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The red used for <code> is a little low on contrast and doesn't meet the WCAG 2.0 AA requirement for a minimum 4.5:1 contrast. This fixes that with a darker version of the same red.