Saving should support a respecEvent #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add event notifications to the save functions so that specifications can, if they wish, subscribe to the events to do processing prior to saving a snapshot (e.g., if a spec has some dynamic content and the author wants to be certain it is in a base state before saving).
Moved the calls to respecEvents.pub into the toString and toXML methods so that they get called even in the event of a browser that supports direct downloading.
|
Does anyone have an objection to my merging in this pull request? |
halindrome
added a commit
that referenced
this pull request
Sep 22, 2014
Saving should support a respecEvent
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
Working a little on that GPA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added calls to respecEvents.pub in the various save methods so that a spec author can subscribe to those methods and perform a cleanup on their specification if they need to before the static version is generated.
NOTE: There is no obvious way to add an automated test for this. I have tested it by the simple expedient of adding a respecEvents.sub("save", function(det) { window.alert("save called with "+det);}) to a document I was working on. The alert was correctly displayed.