fix(core/show-people): more robust error checking #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
commented
May 13, 2021
sidvishnoi
reviewed
May 13, 2021
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
sidvishnoi
reviewed
May 19, 2021
sidvishnoi
reviewed
May 19, 2021
sidvishnoi
reviewed
May 19, 2021
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
marcoscaceres
commented
May 19, 2021
marcoscaceres
commented
May 19, 2021
marcoscaceres
commented
May 19, 2021
marcoscaceres
commented
May 19, 2021
marcoscaceres
commented
May 19, 2021
marcoscaceres
commented
May 19, 2021
marcoscaceres
commented
May 19, 2021
|
@sidvishnoi, I think I've addressed everything now. All good to merge? |
|
I'll run another review in morning. Looking good though. |
marcoscaceres
changed the title
sidvishnoi
reviewed
May 21, 2021
sidvishnoi
reviewed
May 21, 2021
Co-authored-by: Sid Vishnoi <8426945+sidvishnoi@users.noreply.github.com>
sidvishnoi
reviewed
May 21, 2021
sidvishnoi
changed the title
sidvishnoi
changed the title
|
Woot! thanks for the review @sidvishnoi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3530
This is more or less a rewrite of how people are handled/rendered.
This adds more robust error checking.