Changed header numbering logic #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the first heading within a section should be renumbered to match depth. Also, fix-headers.js and structure.js were doing the same thing to the H elements. I removed the duplicate code from structure.js since it was redundant. This fixes Issue #419.
|
@halindrome what do you want to do about this one? |
|
I think it should be merged. @darobin disagrees because headers without a section are somehow bad. |
|
closing this, not because I don't ❤️ ... but because bit rot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the first heading within a section should be
renumbered to match depth.
Also, fix-headers.js and structure.js were doing the same
thing to the H elements. I removed the duplicate code from
structure.js since it was redundant.
This fixes Issue #419.