Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linking to and around WebIDL terms #433

Merged
merged 5 commits into from May 12, 2015

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented May 1, 2015

  • [link-for] used to break non-IDL links in its scope.
  • It was difficult to link to members when their interface wasn't immediately obvious. Now <a>Interface.member</a> works.
  • Now links point to declarations if no definition is available.
  • Any <code> definition now causes its links to also be <code>.

This builds on #432.

@marcoscaceres
Copy link
Member

@jyasskin, sorry, can you rebase please.

@darobin
Copy link
Member

darobin commented May 11, 2015

Yup, #432 was merged but this still can't merge automatically. @jyasskin do you mind fixing?

@jyasskin
Copy link
Member Author

Yep, sorry for the delay. I should get to this today. I may also have found a bug in it, which I need to investigate before merging.

…ied definitions.

Previously, they would only try the qualified title, which broke for paragraphs
containing links to both IDL and non-IDL terms.
…r definition.

Also let links use dotted names to imply the interface they're for.
This recovers some special-casing that used to be handled in webidl-contiguous.js.
@jyasskin
Copy link
Member Author

Here's the rebase with 2 bug fixes.

darobin added a commit that referenced this pull request May 12, 2015
Improve linking to and around WebIDL terms
@darobin darobin merged commit 0da1e4e into w3c:develop May 12, 2015
@darobin
Copy link
Member

darobin commented May 12, 2015

Looks excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants