Use promises to yield between phases #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| var pipeline = Promise.resolve(); |
There was a problem hiding this comment.
We are sure all users of ReSpec are using Promise capable browsers, right? I have not idea if Internet Explorer latest stable supports them... if yes, let's merge this. We can always ask on the mailing list.
There was a problem hiding this comment.
(or does "Promise.min" include some kind of pollyfill?)
There was a problem hiding this comment.
NM, I see the commit message answered my question :)
marcoscaceres
pushed a commit
that referenced
this pull request
May 4, 2015
Use promises to yield between phases
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes browser profiles more meaningful, since each plugin doesn't appear to include the entire runtime of the next plugin.