Improved Member-SUBM and Team-SUBM spec status support #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the spec status is "Member-SUBM" or "Team-SUBM", ReSpec expected a "Previous version" link that does not mean anything in this context, did not set the proper companion logo next to the W3C logo and did not include the right Status of This Document boilerplate. Please note that the links in the SoTD boilerplate for Member submissions still contain "@@@". That is normal since these links are set by W3C Team right before the submissions is accepted, and cannot be computed a priori. ReSpec still conserves the default copyright in that case, but users simply have to use "overrideCopyright" to override that setting. This commit contains a few regression tests.
| @@ -296,6 +296,9 @@ define( | |||
| conf.publishHumanDate = utils.humanDate(conf.publishDate); | |||
| conf.isNoTrack = $.inArray(conf.specStatus, this.noTrackStatus) >= 0; | |||
| conf.isRecTrack = conf.noRecTrack ? false : $.inArray(conf.specStatus, this.recTrackStatus) >= 0; | |||
| conf.isMemberSubmission = conf.specStatus === "Member-SUBM"; | |||
There was a problem hiding this comment.
This looks good, but I noticed that in the status2rdf and status2maturity mapping tables elsewhere in this document there is no mapping for these two types of document. The rdf will require an update to http://www.w3.org/2001/02pd/rec54, which may not be in the offing right now. But what maturity should these be classified as? A special class (SUBMISSION)? Or "NOTE"?
There was a problem hiding this comment.
That's a good question. I see "fromSubmission" in http://www.w3.org/2001/02pd/rec54 that applies to NOTE, so the intent was perhaps to classify Member and Team Submissions as Notes. It makes sense from a maturity perspective at least.
darobin
added a commit
that referenced
this pull request
Aug 4, 2015
Improved Member-SUBM and Team-SUBM spec status support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #458.
When the spec status is "Member-SUBM" or "Team-SUBM", ReSpec expected a
"Previous version" link that does not mean anything in this context, did not
set the proper companion logo next to the W3C logo and did not include the
right Status of This Document boilerplate.
Please note that the links in the SoTD boilerplate for Member submissions still
contain "@@@". That is normal since these links are set by W3C Team right before
the submissions is accepted, and cannot be computed a priori.
ReSpec still conserves the default copyright in that case, but users simply
have to use "overrideCopyright" to override that setting.
This commit contains a few regression tests.