Changed webidl generation to use data-lt attribute #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address issue #464, but I don't have any specs with webidl in them to verify that!
|
@jyasskin can you please take a look? |
| @@ -720,7 +720,7 @@ define( | |||
| // Found it: update the definition to specify its [for] and title. | |||
|
There's also a use of Other than that and the comments, this looks good to me. Thanks. |
|
@marcoscaceres - any chance for progress here? |
|
Merging this, if there are issues with |
marcoscaceres
pushed a commit
that referenced
this pull request
Aug 21, 2015
Changed webidl generation to use data-lt attribute
|
Fwiw I looked at this and data-title is being used for something else.
|
|
Thanks for checking that @halindrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address issue #464, but I don't have any specs with
webidl in them to verify that! Can someone please take a close look?