Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed needing double def of term when data-lt is used (closes #470) #471

Merged
merged 1 commit into from Aug 4, 2015

Conversation

marcoscaceres
Copy link
Member

No description provided.

@marcoscaceres
Copy link
Member Author

Just noticed there was already a normalizeString equiv. called norm.

@marcoscaceres
Copy link
Member Author

  • added additional test for when dfn is normalized to the empty string
  • removed use of .startsWith() as apparently PhantomJS that runs on TravisCI is still in the dark ages?

darobin added a commit that referenced this pull request Aug 4, 2015
Fixed needing double def of term when data-lt is used (closes #470)
@darobin darobin merged commit 830e84f into develop Aug 4, 2015
@darobin
Copy link
Member

darobin commented Aug 4, 2015

@marcoscaceres PhantomJS is pretty much always in the dark ages...

@marcoscaceres marcoscaceres deleted the p470 branch August 6, 2015 23:11
@marcoscaceres
Copy link
Member Author

Maybe in a year or so we can move to https://slimerjs.org/ ... though I see they are also behind :( this is why we can't have nice things.

@darobin
Copy link
Member

darobin commented Aug 7, 2015

We should give jsdom a new shot now that they've fixed their performance issues with ReSpec. Also, I'm told Phantom 2 is actually getting decent(er).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants