Made some initial changes to test new styles #522

halindrome · 2015-11-12T16:36:11Z

Simple changes to load the new stylesheets and
implement some basic changes that make them work.

To enable in your respec document, set

useExperimentalStyles: true,

in your Respec Configuration area.

In response to issue #520

Simple changes to load the new stylesheets and implement some basic changes that make them work. To enable in your respec document, set useExperimentalStyles: true, in your Respec Configuration area. In response to issue #520.

I had mistakenly had it default to 'div'.

@stevefaulkner

Noticed that PR #499 changed the role to navigation. This PR changes the wrapper for TOCs to nav when using the new experimental style sheets. Added code to support both of these. However, note that when using an nav element, the role of navigation may be superfluous. Opinion @stevefaulkner ?

This is to mirror changes in the experimental stylesheet, and is only present with the useExperimentalStyles configuration parameter is true.

If using useExperimentalStyles, then set the class of def on idl containers so that new styles are brought in.

marcoscaceres · 2015-11-15T01:38:11Z

js/core/structure.js

@@ -97,13 +97,19 @@ define(
                if (!conf.noTOC) {
                    var $ul = makeTOCAtLevel($("body", doc), doc, [0], 1, conf);
                    if (!$ul) return;
-                    var $sec = $("<section id='toc'/>").append("<h2 class='introductory'>" + conf.l10n.toc + "</h2>")
+                    var w = ( conf.useExperimentalStyles ? "nav" : "section" );


Maybe just:

var w = conf.useExperimentalStyles ? "nav" : "section";

(updated code above)

marcoscaceres · 2015-11-15T01:49:16Z

Some nits, LGTM tho.

@marcoscaceres

Better support for new styles in notes, examples, and webidl Fixed some code style issues as per @marcoscaceres WebIDL integration with styles is not yet ideal, but will give a decent idea of what it might look like.

plehegar · 2015-11-20T15:43:29Z

We can't merge due to conflicts:

js/w3c/aria.js:

[[
                    var toc = conf.useExperimentalStyles ? $('nav#toc', doc) : $('section#toc', doc);
                    toc.attr('role', 'navigation') ;
=======
                    var toc = $('section#toc', doc).find("ul:first");
                    toc.attr('role', 'directory') ;
]]

tests/spec/core/structure-spec.js

[[
            expect($toc.attr('role')).toEqual('navigation');
=======
            expect($toc.find("ul:first").attr('role')).toEqual('directory');
]]

@halindrome any chance you can resolve them and merge?

halindrome · 2015-11-20T20:17:00Z

Sure. I will look when I get home.
On Nov 20, 2015 9:43 AM, "Philippe Le Hegaret" notifications@github.com
wrote:

We can't merge due to conflicts:

js/w3c/aria.js:
<<<<<<< HEAD
var toc = conf.useExperimentalStyles ? $('nav#toc', doc) :
$('section#toc', doc);
toc.attr('role', 'navigation') ;
            var toc = $('section#toc', doc).find("ul:first");
            toc.attr('role', 'directory') ;
develop

tests/spec/core/structure-spec.js
<<<<<<< HEAD
expect($toc.attr('role')).toEqual('navigation');
    expect($toc.find("ul:first").attr('role')).toEqual('directory');
develop

@halindrome https://github.com/halindrome any chance you can resolve
them and merge?

—
Reply to this email directly or view it on GitHub
#522 (comment).

halindrome · 2015-11-21T15:59:41Z

This is taken care of and I pushed a new version. I am going to open a new
issue and tag you with an idea I havea.

On Fri, Nov 20, 2015 at 2:16 PM, Shane McCarron halindrome@gmail.com
wrote:

Sure. I will look when I get home.
On Nov 20, 2015 9:43 AM, "Philippe Le Hegaret" notifications@github.com
wrote:
We can't merge due to conflicts:

js/w3c/aria.js:
<<<<<<< HEAD
var toc = conf.useExperimentalStyles ? $('nav#toc', doc) :
$('section#toc', doc);
toc.attr('role', 'navigation') ;
            var toc = $('section#toc', doc).find("ul:first");
            toc.attr('role', 'directory') ;
develop

tests/spec/core/structure-spec.js
<<<<<<< HEAD
expect($toc.attr('role')).toEqual('navigation');
    expect($toc.find("ul:first").attr('role')).toEqual('directory');
develop

@halindrome https://github.com/halindrome any chance you can resolve
them and merge?

—
Reply to this email directly or view it on GitHub
#522 (comment).

Shane McCarron
halindrome@gmail.com

marcoscaceres · 2015-11-26T01:55:30Z

js/w3c/style.js

@@ -40,6 +40,9 @@ define(
                        .appendTo($("head"))
                        ;
                }
+                else if (conf.useExperimentalStyles) {
+                    css = "http://fantasai.inkedblade.net/style/design/w3c-restyle/2016/W3C-" + statStyle;


D'oh. Can't believe I didn't see this :(

Well - that's where the stylesheets are. Should we have done something
else?

On Wed, Nov 25, 2015 at 7:55 PM, Marcos Caceres notifications@github.com
wrote:

In js/w3c/style.js
#522 (comment):

@@ -40,6 +40,9 @@ define(
.appendTo($("head"))
;
}

else if (conf.useExperimentalStyles) {

css = "http://fantasai.inkedblade.net/style/design/w3c-restyle/2016/W3C-" + statStyle;

D'oh. Can't believe I didn't see this :(

—
Reply to this email directly or view it on GitHub
https://github.com/w3c/respec/pull/522/files#r45938038.

Shane McCarron
halindrome@gmail.com

On 27 Nov 2015, at 3:14 AM, Shane McCarron notifications@github.com wrote:

In js/w3c/style.js:

@@ -40,6 +40,9 @@ define(
.appendTo($("head"))
;
}

else if (conf.useExperimentalStyles) {

css = "http://fantasai.inkedblade.net/style/design/w3c-restyle/2016/W3C-" + statStyle;
Well - that's where the stylesheets are. Should we have done something else?

Yeah, we should have stopped and complained that http is unacceptable in 2015. We should make that a rule going forward.

The project is hosted on Github, so we could ask @fantasai to just serve it from gh-pages (it probably already is, but too lazy to check from my phone:))

…
—
Reply to this email directly or view it on GitHub.

plehegar · 2015-12-04T14:39:54Z

Can we close this one now?

plehegar · 2015-12-04T14:40:18Z

oops nevermind.

halindrome added 6 commits November 12, 2015 10:33

Made some initial changes to test new styles

88b2dc2

Simple changes to load the new stylesheets and implement some basic changes that make them work. To enable in your respec document, set useExperimentalStyles: true, in your Respec Configuration area. In response to issue #520.

Changed wrapper on toc back to section

0ab38fb

I had mistakenly had it default to 'div'.

Fixed the logo background.

56a64e9

Added TOC link at bottom of document

fa05da5

This is to mirror changes in the experimental stylesheet, and is only present with the useExperimentalStyles configuration parameter is true.

Set additional class on webidl containers

71acd2a

If using useExperimentalStyles, then set the class of def on idl containers so that new styles are brought in.

marcoscaceres reviewed Nov 15, 2015
View reviewed changes

Addressed some comments

c280e33

Better support for new styles in notes, examples, and webidl Fixed some code style issues as per @marcoscaceres WebIDL integration with styles is not yet ideal, but will give a decent idea of what it might look like.

plehegar added the enhancement label Nov 20, 2015

halindrome merged commit c280e33 into develop Nov 20, 2015

plehegar mentioned this pull request Nov 25, 2015

Use the experimental 2016 stylesheets for EDs #520

Closed

marcoscaceres reviewed Nov 26, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Made some initial changes to test new styles #522

Made some initial changes to test new styles #522

halindrome commented Nov 12, 2015

marcoscaceres Nov 15, 2015

marcoscaceres Nov 15, 2015

marcoscaceres commented Nov 15, 2015

plehegar commented Nov 20, 2015

halindrome commented Nov 20, 2015

halindrome commented Nov 21, 2015

marcoscaceres Nov 26, 2015

halindrome Nov 26, 2015

marcoscaceres Nov 26, 2015

plehegar commented Dec 4, 2015

plehegar commented Dec 4, 2015

Made some initial changes to test new styles #522

Made some initial changes to test new styles #522

Conversation

halindrome commented Nov 12, 2015

marcoscaceres Nov 15, 2015

Choose a reason for hiding this comment

marcoscaceres Nov 15, 2015

Choose a reason for hiding this comment

marcoscaceres commented Nov 15, 2015

plehegar commented Nov 20, 2015

halindrome commented Nov 20, 2015

halindrome commented Nov 21, 2015

marcoscaceres Nov 26, 2015

Choose a reason for hiding this comment

halindrome Nov 26, 2015

Choose a reason for hiding this comment

marcoscaceres Nov 26, 2015

Choose a reason for hiding this comment

plehegar commented Dec 4, 2015

plehegar commented Dec 4, 2015