Add --exclude-script to respec2html #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +31,13 @@ if (args.indexOf("-w") !== -1) { | |||
| reportWarnings = true; | |||
| } | |||
|
|
|||
| if (args.indexOf("--exclude-script") !== -1) { | |||
| var idx = args.indexOf("--exclude-script"); | |||
| var values = args.splice(idx, 2); | |||
There was a problem hiding this comment.
Are you certain you want "splice" here (instead of slice)? Splice modifies the args array, which is not great IMO (i.e., we should keep inputs immutable).
There was a problem hiding this comment.
I've re-used here the approach taken in the two previous argument parsing blocks.
|
LGTM |
|
Doesn't this only permit one exclusion instead of a list of exclusions? |
|
it filters any scripts whose source starts with the url passed in parameter; I could support several of those, but that doesn't seem required yet |
|
👍 |
plehegar
added a commit
that referenced
this pull request
Dec 19, 2015
Add --exclude-script to respec2html
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
…rtain elements should exist on a graph, such as the plot bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #538