Align new TR design with latest requirements #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
plehegar
commented
Feb 9, 2016
plehegar
commented
- removed width = content-width from viewport
- add fixup.js
halindrome
added a commit
that referenced
this pull request
Feb 9, 2016
Align new TR design with latest requirements
| statStyle === "LC-NOTE") statStyle = "WD"; | ||
| if (statStyle === "FPWD-NOTE") statStyle = "WG-NOTE"; | ||
| if (statStyle === "finding" || statStyle === "draft-finding") statStyle = "base"; | ||
| var fixup = "null"; |
There was a problem hiding this comment.
Note, there is a bug here. it is set to the string "null", but later you check if it's null.
|
@plehegar, @halindrome, I'm not comfortable with this module and feel it should be backed out. I can see that it was kinda slapped together quickly and I don't think it's release quality (e.g., duplicates code, lacks tests, doesn't adhere to new coding conventions). Apart from using the "experimental" style, it seems that updating |
|
Another question: is this module time sensitive? |
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.