Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make jquery-enhanced get used in right places places #598

Closed
wants to merge 16 commits into from

Conversation

marcoscaceres
Copy link
Member

No description provided.

@marcoscaceres
Copy link
Member Author

@halindrome, this should fix #597. Please review.

@halindrome
Copy link
Contributor

This does not appear fixed to me. Use case: data-include is used to bring in an external file. data-oninclude is used to transform the content of that file. The function called uses jQuery constructs and the functions in core/jquery-enhanced are not available. Not sure what I am missing. If you want an example try http://pandora.aptest.com/w3c/aria-current/aria/aria.html - It references a version of respec that is built using this branch.

@marcoscaceres
Copy link
Member Author

The simplest solution is just to include jquery-enhanced everywhere.

@marcoscaceres
Copy link
Member Author

Will do that now.

@halindrome
Copy link
Contributor

Just checking - do you think this is working now??

@marcoscaceres
Copy link
Member Author

Not yet. Hopefully Monday. Found some other broken things that are blocking this one.

Sent from my iPhone

On 5 Mar 2016, at 3:36 AM, Shane McCarron notifications@github.com wrote:

Just checking - do you think this is working now??


Reply to this email directly or view it on GitHub.

@marcoscaceres
Copy link
Member Author

Ok, I think this is working... but need to break it up into smaller commits.

@marcoscaceres
Copy link
Member Author

Today was a sad day - I swear i had it working and then it blew up. Getting close tho.

@marcoscaceres
Copy link
Member Author

Ok, going to see what can be salvaged from here.... closing this PR, as #623 now includes at lot of this.

@marcoscaceres marcoscaceres deleted the fix_utils branch May 24, 2016 05:18
shikhar-scs pushed a commit to shikhar-scs/respec that referenced this pull request Feb 19, 2018
…rly ironed-out for these kinds of use cases
shikhar-scs pushed a commit to shikhar-scs/respec that referenced this pull request Feb 19, 2018
…lly how color_accessor works), and w3c#602 (coloring , implementation of group_accessor, legend work)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants