Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug291 no rec track should add note #601

Merged
merged 2 commits into from Mar 4, 2016
Merged

Bug291 no rec track should add note #601

merged 2 commits into from Mar 4, 2016

Conversation

marcoscaceres
Copy link
Member

Review please 😄

@halindrome
Copy link
Contributor

Did someone ask for this change? I don't remember a bug report about it.

@marcoscaceres
Copy link
Member Author

It's in the 3.2 milestone (see #291). Robin filed it. I'm working my way through the 3.2 list.

Sent from my iPhone

On 4 Mar 2016, at 1:28 AM, Shane McCarron notifications@github.com wrote:

Did someone ask for this change? I don't remember a bug report about it.

—
Reply to this email directly or view it on GitHub.

@halindrome
Copy link
Contributor

Oh! Then sure. It LGTM. However, if we could fix the critical path problem with data-oninclude first that would be super helpful.

@marcoscaceres
Copy link
Member Author

Will try to do the data-oninclude today.

Sent from my iPhone

On 4 Mar 2016, at 9:31 AM, Shane McCarron notifications@github.com wrote:

Oh! Then sure. It LGTM. However, if we could fix the critical path problem with data-oninclude first that would be super helpful.

—
Reply to this email directly or view it on GitHub.

marcoscaceres pushed a commit that referenced this pull request Mar 4, 2016
Merge pull request #601 from w3c/BUG291-noRecTrack-should-add-Note
4a22782 
Bug291 no rec track should add note
@marcoscaceres marcoscaceres merged commit 4a22782 into develop Mar 4, 2016
@marcoscaceres marcoscaceres deleted the BUG291-noRecTrack-should-add-Note branch March 4, 2016 02:07
@marcoscaceres marcoscaceres mentioned this pull request Mar 11, 2016
Closed
shikhar-scs pushed a commit to shikhar-scs/respec that referenced this pull request Feb 19, 2018
@hamilton
fixes w3c#601. Removing clip path entirely from points for the moment…
8c02a48 
…. The clip path tends to cut off parts of points that are within the bounds but whose radius extends beyond the plot area.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcoscaceres @halindrome