Fix source maps #614
Merged
Fix source maps #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
fix_source_maps
branch
4 times, most recently
from
70da002
to
e1c2957
Compare
|
Ok, this gives us the first steps towards using source maps in testing. However, browser support is spotty. @halindrome, r? |
I had incorrectly assumed that the source map filename would be the built filename + `.map`. It's actually auto-generated, but not directly returned, by the Requirejs optimizer. It now generates the correct file which is profile-w3c-common.build.js.map. Feat (test-build.js): use chai for testing instead Feat (builder.js): Allow sourcemap to be versioned. Fix (test-build.js): fix shebang so test can be run via mocha instead of node Fix (test-build.js): moved to tests directory Fix (respec-w3c-common.build.js.map): map is now named correctly Fix (.jshintrc): conflict in files
marcoscaceres
force-pushed
the
fix_source_maps
branch
from
e1c2957
to
6dbb53a
Compare
|
@halindrome, while I fix the other ones, I'd like to get this landed. If you have time, would really appreciate a review. Other people watching this repo, can anyone else help with reviews? |
|
Ping |
|
Looking. |
|
Tests seem to pass - LGTM. |
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
…nt and bars. Lines up next.
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@halindrome, this gets source maps working correctly. I still think we need to try this out a bit before we commit to it. According the RequireJS documentation, source maps are still "experimental".