Fix (release.js): Protect against EPIPE bombs from npmjs (closes #645). #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -214,4 +222,4 @@ async.task(function * () { | |||
| () => process.exit(0) | |||
| ).catch( | |||
| err => console.error(err) | |||
| ); | |||
| ); | |||
There was a problem hiding this comment.
No newline at end of file?
marcoscaceres
force-pushed
the
fix_npm_publish
branch
from
415560a
to
f07a944
Compare
* Adds epipebomb package, which swallows EPIPE errors. * Adds a default timeout to `toExecPromise`, and the ability to override it. * Increases timeout for npm publish.
marcoscaceres
force-pushed
the
fix_npm_publish
branch
from
f07a944
to
1d0a601
Compare
|
my editor decided to eat new lines at the end of docs :/ |
|
huh. ok. LGTM. no real way for me to test it except to attempt a node tools/release.js when we are ready |
marcoscaceres
pushed a commit
that referenced
this pull request
Mar 15, 2016
Fix (release.js): Protect against EPIPE bombs from npmjs (closes #645).
|
@halindrome that's how we roll, "test release in release!" we are 🐮+👦z! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toExecPromise, and the ability to override it.