Feat(respecDocWriter): throw if not a ReSpec doc (closes #704) #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tripu or @dontcallmedom, wdty? |
|
I'll make it look like this:
|
|
Argh! Need an emoji in there too! |
marcoscaceres
force-pushed
the
bug_704_stop_on_norespec
branch
from
7ee41c5
to
f11711d
Compare
| return document.readyState === "complete"; | ||
| }) | ||
| .evaluate(function(){ | ||
| const selector = "script[src='https://www.w3.org/Tools/respec/respec-w3c-common']"; |
There was a problem hiding this comment.
can't you test the presence of a ReSpec global (assuming there is still such a thing)?
Relying the the URL detection makes the tool more brittle (I know I've used it on locally hosted version of respec for instance)
There was a problem hiding this comment.
I'll add that as first check. Problem is that I've seen people add ReSpec asycn. I'll add as first check:
if(document.hasOwnProperty("respectIsReady")){
return true;
}
c61c2d2
to
a41ad59
Compare
* Add check for respecIsReady on document object as first check * Added color + emoji * Fixed color of HTTP error also
marcoscaceres
force-pushed
the
bug_704_stop_on_norespec
branch
from
a41ad59
to
0bfed3e
Compare
|
Even better with moar emoji... even @nrooney would approve.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.