Just to put this on your radar #712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de blocks, with highlight.js to allow for language to be specified in the Markdown
|
@nickevansuk, this is great to see. I had filed a bug to do this (#581), but ran into difficulties on my first attempt - so it's great to see you got it working. Would love to coordinate on upgrading marked.js and the highlighter. |
|
Closing this for now - but looking forward to collaborating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Marcos,
Just to let you know that the new version of the marked library includes table support for markdown, which you can activate if you switch to gfm mode. It also works quite nicely with highlight.js which I've also added for markdown mode (though understand you already have google-code-prettify in there so maybe don't want to conflate the two for the W3C usecase).
Anyway here's the code - let me know if you want me to cherry pick some of the changes into a proper pull request for you. I still need to fix the unit tests to work with gfm so it's not ready as-is.
We're a new W3C CG and we're using Respec for our specs - so will continue to pull request changes we make in case they're useful. Let me know if this is of interest.
Great work on Respec by the way! Robin's left a solid legacy with this, so well done for carrying the torch!
Thanks,
Nick