Feat(global): add hightlighter and beautifier as deps #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcoscaceres
commented
May 13, 2016
marcoscaceres
commented
- adds to package dependencies: highlight.js and jsbeautifier
- adds default options for beautifier (beautify-options.js)
- tells builder to include highlighter and beautifier
- Sets appropriate paths in profile-w3c-common.js
* adds to package dependencies: highlight.js and jsbeautifier * adds default options for beautifier (beautify-options.js) * tells builder to include highlighter and beautifier * Sets appropriate paths in profile-w3c-common.js
|
This is Part 1 of some incoming pull requests.... |
|
Once these land, I can send the rest. |
|
@marcoscaceres I've looked at the changes and they look OK, but I was not sure what observable changes in the output of ReSpec I should be looking for — can you say a bit more? |
|
@dontcallmedom nothing will change yet. This is just laying down the infrastructure. All the cool stuff if coming next :) It's all in this branch: |
|
@dontcallmedom, I have to send it in pieces, as they all build on each other and it's a lot of code that's about to come in. I also want to make sure tests keep passing, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.