Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(utils): correctly calculate leftPad #757

Merged
merged 2 commits into from May 17, 2016
Merged

Fix(utils): correctly calculate leftPad #757

merged 2 commits into from May 17, 2016

Conversation

marcoscaceres
Copy link
Member

  • Fixes some edge cases that I missed previously for markdown.

@marcoscaceres
Copy link
Member Author

@halindrome or @dontcallmedom r?

marcoscaceres
marcoscaceres reviewed May 15, 2016
View reviewed changes
js/core/utils.js
return NodeFilter.FILTER_REJECT;
}

function toESIterable(nodeIterator) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've decided to move this to utils

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I mean into it's own method within utils.js

@marcoscaceres marcoscaceres force-pushed the fix_left_pad_calc branch 2 times, most recently from fa363d2 to 3b2899d Compare May 16, 2016 05:47
@marcoscaceres
Copy link
Member Author

Added test for toESIterable()

marcoscaceres
marcoscaceres reviewed May 17, 2016
View reviewed changes
js/core/utils.js
* methods that can interface with Iterators (Array.from(), etc.).
*
* @param {Function} nextLikeFunction A function that a next value;
* @return {Object} An object that implements the Iterator prop.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@marcoscaceres
Copy link
Member Author

Performed self-review, to avoid bit rot.

@marcoscaceres marcoscaceres merged commit e6b4559 into develop May 17, 2016
@marcoscaceres marcoscaceres deleted the fix_left_pad_calc branch May 24, 2016 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marcoscaceres