Feat(global): link to HTTPS urls (closes #749) #782
Conversation
marcoscaceres
force-pushed
the
Bug_749_transition_to_tls
branch
from
f189a39
to
258ee90
Compare
|
Fixed tests |
marcoscaceres
force-pushed
the
Bug_749_transition_to_tls
branch
from
258ee90
to
36c3486
Compare
|
All the links appear to work fine |
marcoscaceres
force-pushed
the
Bug_749_transition_to_tls
branch
from
36c3486
to
8a16c19
Compare
|
@plehegar, @dontcallmedom is it ok to merge and release this? Or do we need to wait for some particular date? |
marcoscaceres
force-pushed
the
Bug_749_transition_to_tls
branch
from
8a16c19
to
4a24b88
Compare
|
Rebased |
|
Until we make the switch official, you shouldn't release this, otherwise it's going to break publications. And we can't make the switch until we get an ok on the specref side :( |
|
@plehegar, maybe we can land this in pieces? Like we could start with some of the URLs that don't relate to the publication (e.g., boilerplate ones). Can pubrules handle those? |
|
@plehegar ping |
marcoscaceres
force-pushed
the
Bug_749_transition_to_tls
branch
from
4a24b88
to
f9576e8
Compare
marcoscaceres
force-pushed
the
Bug_749_transition_to_tls
branch
from
f9576e8
to
dd8fd93
Compare
|
Rebased... blocked on #792 |
marcoscaceres
force-pushed
the
Bug_749_transition_to_tls
branch
from
dd8fd93
to
5837272
Compare
|
@deniak pointed out that the patentURI reference is http:. this URI and some others are supplied by the spec. If any of these URIs point into w3.org I imagine we should just change them to https - right? And maybe add checks into the "linter" that warn if URIs into w3.org are not secure. |
|
Correct. The linter should already catch these and ask the editor to change them. We could auto-fix these on spec generation, however.
|
to be clear, that was a mistake in my spec, not a mistake with ReSpec. |
* develop: v4.3.0 style(release): fix typo chore(package): update karma-mocha-reporter to version 2.1.0 (#895) chore(package): update snyk to version 1.17.5 (#894) Feat(global): link to HTTPS urls (closes #749) (#782) chore(package): update karma-mocha-reporter to version 2.0.5 (#892) chore(package): update snyk to version 1.17.4 (#891) chore(package): update karma to version 1.1.2 (#889) chore(package): update snyk to version 1.17.3 (#890) chore(package): update snyk to version 1.17.2 (#888) fix(headless): skip webidl-contiguous.html style(make-test-file-build): style code a little better feat(save-html): Add meta tag generator (closes #805) (#887) test(headless): filter out contiguous.html
@plehegar r?
This change is