Allow additional logo in CG spec

[nickevansuk]

Allow for additional logos in the CG spec template

---

This change is

[halindrome]

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

js/w3c/templates/cgbg-headers.html, line 5 [r1] (raw file):

    <a class='logo' href='http://www.w3.org/'><img width='72' height='48' src='https://www.w3.org/StyleSheets/TR/2016/logos/W3C' alt='W3C'></a>
  </p>
  <p>

The showLogos function embeds the logos in a p element already. I don't think you need the P in here.

---

Comments from Reviewable

[marcoscaceres]

Please be sure to add a test or two. Let me know if you need a hand or anything.

[nickevansuk]

Have fixed <p> tag situation @halindrome, thanks. Though I should mention I just copied it from w3c/templates/headers.html (which also includes <p> tags). Should that also be corrected?

@marcoscaceres considering this feature exists on other templates, where would you advise adding a test?

[marcoscaceres]

@nickevansuk, looks like tests/spec/w3c/headers-spec.js would be the right place to add a test. It would just be a simple like:

  it("adds multiple logos to CG spec", function(done) {
    var ops = makeStandardOps();
    var newProps = {
       specSatus: "CG-DRAFT", 
       logos: [{}, {}]
    };
    Object.assign(ops.config, newProps);
    makeRSDoc(ops, function(doc) {
      // Find the logos
      // Please avoid using jQuery here - we are trying to stop relying on it 
    }).then(done);
  });

[marcoscaceres]

@nickevansuk, in the test above, you want to check against both specStatus "CG-DRAFT", and "CG-FINAL" . You can get the logo code from the logos example in our Wiki.

[marcoscaceres]

I'll add tests for this locally, but the change is tiny and just reuses existing infra.