Feat(w3c/style): preload for css, scripts (see #663) #838

marcoscaceres · 2016-06-23T01:22:47Z

This mostly helps github hosted editor's drafts.

marcoscaceres · 2016-06-23T02:19:08Z

js/w3c/style.js

+      var preconnectLink = document.createElement("link");
+      preconnectLink.rel = "preconnect";
+      preconnectLink.href = "https://www.w3.org";
+      preconnectLink.crossorigin = true;


Should be "crossOrigin"

and = "anonymous";

marcoscaceres · 2016-06-25T08:26:34Z

js/w3c/style.js

@@ -10,8 +10,6 @@ define(
    function(utils, pubsubhub) {
      function attachFixupScript(doc, version){
        var script = doc.createElement("script");
-        script.async = true;
-        script.defer = true;


So, my reading is that because this script is pre-loaded, we don't need to defer it. And as it's already at the end of the document (and added after processing), async won't matter.

marcoscaceres · 2016-06-25T09:26:32Z

Before:

After:

😻

Important where base.css comes in now.

We are still getting like 4-5 repaints tho, which really sucks.

marcoscaceres · 2016-06-25T10:25:28Z

Made a couple more performance improvements... main bottleneck seems to be handlebars tho... once we compile the templates, we should see maybe another ±10% gain. It's noticeably better now tho. Way less thrashing.

halindrome · 2016-06-25T16:35:26Z

I sort of forgot that there was handlebars under the covers. I wonder if
other organizations that use ReSpec have their own templates that are
getting populated? Also, is the handlebars functionality available for the
content of a document? In other words, could I use handlebars in my specs
to do value substitution at doc generation time?

On Sat, Jun 25, 2016 at 5:25 AM, Marcos Cáceres notifications@github.com
wrote:

Made a couple more performance improvements... main bottleneck seems to be
handlebars tho... once we compile the templates, we should see maybe
another ±10% gain. It's noticeably better now tho. Way less thrashing.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#838 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAfx8JWJFBcQf3dj5nsj9oRPN7k74PpNks5qPQIYgaJpZM4I8Xwh
.

Shane McCarron
halindrome@gmail.com

marcoscaceres · 2016-06-26T00:26:59Z

On 26 Jun 2016, at 2:35 AM, Shane McCarron notifications@github.com wrote:

I sort of forgot that there was handlebars under the covers. I wonder if
other organizations that use ReSpec have their own templates that are
getting populated?

It's likely, but given their complexity: odds are low.

Also, is the handlebars functionality available for the
content of a document?

I don't think so. Only should be in tmpl.js.

In other words, could I use handlebars in my specs
to do value substitution at doc generation time?

Only if you require() it.

On Sat, Jun 25, 2016 at 5:25 AM, Marcos Cáceres notifications@github.com
wrote:

Made a couple more performance improvements... main bottleneck seems to be
handlebars tho... once we compile the templates, we should see maybe
another ±10% gain. It's noticeably better now tho. Way less thrashing.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#838 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAfx8JWJFBcQf3dj5nsj9oRPN7k74PpNks5qPQIYgaJpZM4I8Xwh
.

Shane McCarron
halindrome@gmail.com
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

marcoscaceres · 2016-06-26T01:22:36Z

@halindrome, would you mind reviewing?

I was just looking for @yoavweiss feedback on approach and if he had any additional suggestions.

marcoscaceres · 2016-06-28T00:14:02Z

js/core/utils.js

@@ -84,7 +102,54 @@ define(
          }, +Infinity);
        return (leftPad === +Infinity) ? 0 : leftPad;
      },
-
+      /**
+       * Creates a link element to use as a resource hint.


Should say, "represents a resource hint" and maybe link to spec

marcoscaceres · 2016-06-28T02:42:37Z

Did a couple of rounds of self review over last few days. Additional comments welcome.

marcoscaceres force-pushed the preload-fixup branch 2 times, most recently from 7f95f6a to ebb3a00 Compare June 23, 2016 01:39

marcoscaceres reviewed Jun 23, 2016
View reviewed changes

marcoscaceres force-pushed the preload-fixup branch 2 times, most recently from e3b62d9 to ede9076 Compare June 23, 2016 14:14

marcoscaceres added 4 commits June 24, 2016 12:19

Feat(w3c/style): preload for css, scripts (see #663)

76af2af

Feat(utils): utils is not a runnable

ac98029

Feat(utils): add createResourceHint()

22dd615

Feat(utils-spec): add tests for createResourceHint()

ccd1aed

marcoscaceres force-pushed the preload-fixup branch 2 times, most recently from 513d117 to 4201fd5 Compare June 24, 2016 02:24

marcoscaceres added 8 commits June 25, 2016 17:48

fix(karma.conf): include fetch for Safari

c8bd517

fix(profile-w3c-common): add style as early as possible

79c4ea7

Feat(w3c/style): Generalize opportunistic preload/preconnect

0858054

chore(utils): doc for createResourceHint's opts.as

60dc066

feat(utils): tag resource hints for removal

850f61e

Feat(biblio): dns-prefetch bibref's origin

81a83d2

feat(utils-spec): tests for resource hint default removal

bc295bb

feat(biblio-spec): add dns-prefetch test

53f3223

marcoscaceres force-pushed the preload-fixup branch from 4201fd5 to 53f3223 Compare June 25, 2016 08:10

marcoscaceres reviewed Jun 25, 2016
View reviewed changes

feat(w3c/style): preload base.css and logo

be62848

chore(perf): performance improvements

63e68d3

chore(w3c/style): switch to base.css to match w3c

1b50a1d

marcoscaceres reviewed Jun 28, 2016
View reviewed changes

marcoscaceres added 3 commits June 28, 2016 12:19

chore(w3c/style): refactor resource hint to map/reduce

8482a27

chore(biblio): code style consitency

93bab97

fix(utils): createResourceHint() description

e5d1077

marcoscaceres merged commit fce1b4a into develop Jun 28, 2016

marcoscaceres deleted the preload-fixup branch June 28, 2016 02:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(w3c/style): preload for css, scripts (see #663) #838

Feat(w3c/style): preload for css, scripts (see #663) #838

marcoscaceres commented Jun 23, 2016 •

edited

marcoscaceres Jun 23, 2016

marcoscaceres Jun 23, 2016

marcoscaceres Jun 25, 2016

marcoscaceres commented Jun 25, 2016

marcoscaceres commented Jun 25, 2016

halindrome commented Jun 25, 2016

marcoscaceres commented Jun 26, 2016

marcoscaceres commented Jun 26, 2016

marcoscaceres Jun 28, 2016

marcoscaceres commented Jun 28, 2016

Feat(w3c/style): preload for css, scripts (see #663) #838

Feat(w3c/style): preload for css, scripts (see #663) #838

Conversation

marcoscaceres commented Jun 23, 2016 • edited

marcoscaceres Jun 23, 2016

Choose a reason for hiding this comment

marcoscaceres Jun 23, 2016

Choose a reason for hiding this comment

marcoscaceres Jun 25, 2016

Choose a reason for hiding this comment

marcoscaceres commented Jun 25, 2016

marcoscaceres commented Jun 25, 2016

halindrome commented Jun 25, 2016

marcoscaceres commented Jun 26, 2016

marcoscaceres commented Jun 26, 2016

marcoscaceres Jun 28, 2016

Choose a reason for hiding this comment

marcoscaceres commented Jun 28, 2016

marcoscaceres commented Jun 23, 2016 •

edited