Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(respec2.css): th code inherit color (closes #877) #880

Merged
merged 1 commit into from Jul 20, 2016
Merged

fix(respec2.css): th code inherit color (closes #877) #880

merged 1 commit into from Jul 20, 2016

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres
Copy link
Member Author

Just inherits from table:

screenshot 2016-07-20 18 54 01

@patrickhlauke
Copy link
Member

me gusta. +1

@halindrome
Copy link
Contributor

LGTM but I wonder if someone from A11Y can check it for WCAG color contrast requirements?

@patrickhlauke
Copy link
Member

patrickhlauke commented Jul 20, 2016 •
edited

foreground #fff, background #005a9c - color contrast ratio 7.1:1, well above the minimum 4.5:1 (tested using https://www.paciellogroup.com/resources/contrastanalyser/)

in short, yup, looks good.

@marcoscaceres
Copy link
Member Author

Thanks you both! Will release first thing tomorrow.

@marcoscaceres marcoscaceres merged commit 4a263e5 into develop Jul 20, 2016
@marcoscaceres marcoscaceres deleted the bug_877_code_in_th branch July 20, 2016 14:01
marcoscaceres added a commit that referenced this pull request Jul 21, 2016
@marcoscaceres
Merge branch 'develop' into gh-pages
1418f96 
* develop:
  v4.1.2
  docs: deprecation warning should point to wiki (#875)
  fix: increase contrast for .parameters th and .exceptions th text (#883)
  chore(package): update promise-polyfill to version 6.0.0 (#881)
  fix(respec2.css): th code inherit color (closes #877) (#880)
  Fix(figures): figures so more than one link can be made to figures (#822)
  chore(package): update snyk to version 1.17.1 (#876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcoscaceres @patrickhlauke @halindrome