Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"current settings object's associated Document" is not defined #346

Closed
Ms2ger opened this issue Sep 15, 2022 · 2 comments · Fixed by #347
Closed

"current settings object's associated Document" is not defined #346

Ms2ger opened this issue Sep 15, 2022 · 2 comments · Fixed by #347

Comments

@Ms2ger
Copy link

Ms2ger commented Sep 15, 2022

Should be "current global object's associated Document
@rakuco
Copy link
Member

rakuco commented Sep 15, 2022

I guess this also applies to "relevant settings object's associated Document" in https://w3c.github.io/screen-wake-lock/#the-request-method too?

Has the association changed in HTML recently? I'm asking because the current text was added by @domenic back in #311 when adapting to some other changes in the HTML spec.

@Ms2ger
Copy link
Author

Ms2ger commented Sep 15, 2022

Yeah, settings objects don't have an associated Document, global objects do. This is what @domenic was trying to fix in #311, but it seems like the change was incomplete.

@rakuco rakuco mentioned this issue Sep 15, 2022
Merged
rakuco added a commit to rakuco/wake-lock that referenced this issue Sep 15, 2022
@rakuco
editorial: Fetch an associated document from a global, not settings o…
d82d991 
…bject

A settings object does not have an associated document; a global object
does.

Grab the associated document from the right place after w3c#311 ('Editorial:
remove uses of "responsible document"').

Fixes w3c#346.
rakuco added a commit that referenced this issue Sep 16, 2022
@rakuco
editorial: Fetch an associated document from a global, not settings o…
8af30a8 
…bject (#347)

A settings object does not have an associated document; a global object
does.

Grab the associated document from the right place after #311 ('Editorial:
remove uses of "responsible document"').

Fixes #346.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editorial: Fetch an associated document from a global, not settings object rakuco/wake-lock
2 participants
@rakuco @Ms2ger