Improve wording in the "Sensor garbage collection" session #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Eligible for garbage collection" can sound ambiguous and lead to implementers thinking this is a step that happens prior to garbage collection itself, whereas the original intent of the text added in pull request w3c#248 ("Be explicit about steps taken when a Sensor instance is GCed") was that a sensor that _is being GCed_ must be deactivated if necessary. Fixes w3c#372.
|
@rakuco thanks, looks good to me. (The |
|
@rakuco, this change makes the garbage collection behavior clear. Thank you. |
|
@reillyeon, PTAL and merge if you’re happy with this clarification. |
reillyeon
approved these changes
Sep 25, 2018
|
These changes look good to me but I don't have permission to merge. |
|
@reillyeon, please check your inbox :-) |
|
It looks like GItHub is taking its time actually granting me the powers it says I have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Eligible for garbage collection" can sound ambiguous and lead to
implementers thinking this is a step that happens prior to garbage
collection itself, whereas the original intent of the text added in pull
request #248 ("Be explicit about steps taken when a Sensor instance is
GCed") was that a sensor that is being GCed must be deactivated if
necessary.
Fixes #372.
Preview | Diff