Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording in the "Sensor garbage collection" session #373

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
4 participants
@rakuco
Copy link
Contributor

commented Sep 25, 2018

"Eligible for garbage collection" can sound ambiguous and lead to
implementers thinking this is a step that happens prior to garbage
collection itself, whereas the original intent of the text added in pull
request #248 ("Be explicit about steps taken when a Sensor instance is
GCed") was that a sensor that is being GCed must be deactivated if
necessary.

Fixes #372.


Preview | Diff

Improve wording in the "Sensor garbage collection" session
"Eligible for garbage collection" can sound ambiguous and lead to
implementers thinking this is a step that happens prior to garbage
collection itself, whereas the original intent of the text added in pull
request #248 ("Be explicit about steps taken when a Sensor instance is
GCed") was that a sensor that _is being GCed_ must be deactivated if
necessary.

Fixes #372.
@rakuco

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2018

@anssiko @phoddie Let me know if this is enough to clarify any confusion surrounding this topic or if it's just related to #372 but does not fix it.

index.html has quite a few unrelated changes, but I guess it's just due to a different Bikeshed version being used.

@anssiko

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

@rakuco thanks, looks good to me.

(The index.html noise is indeed due to Bikeshed version differences. I just pulled in the latest to confirm.)

@phoddie

This comment has been minimized.

Copy link

commented Sep 25, 2018

@rakuco, this change makes the garbage collection behavior clear. Thank you.

@anssiko

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

@reillyeon, PTAL and merge if you’re happy with this clarification.

@reillyeon

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2018

These changes look good to me but I don't have permission to merge.

@anssiko

This comment has been minimized.

Copy link
Member

commented Sep 25, 2018

@reillyeon, please check your inbox :-)

@reillyeon

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2018

It looks like GItHub is taking its time actually granting me the powers it says I have.

@reillyeon reillyeon merged commit ac1df04 into w3c:master Sep 25, 2018

1 check passed

ipr PR deemed acceptable.
Details

@rakuco rakuco deleted the rakuco:sensor-gc-wording branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.