Be explicit about steps taken when a Sensor instance is GCed #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.bs
Outdated
| @@ -829,6 +829,8 @@ The [=task source=] for the [=tasks=] mentioned in this specification is the <df | |||
| </g> | |||
| </svg> | |||
|
|
|||
| When a {{Sensor}} object is eligible for garbage collection, the user agent should | |||
pozdnyakov
force-pushed
the
sensor_object_gced
branch
from
669da1d
to
538cfdd
Compare
rwaldron
approved these changes
Aug 3, 2017
rakuco
added a commit
to rakuco/sensors
that referenced
this pull request
Sep 25, 2018
"Eligible for garbage collection" can sound ambiguous and lead to implementers thinking this is a step that happens prior to garbage collection itself, whereas the original intent of the text added in pull request w3c#248 ("Be explicit about steps taken when a Sensor instance is GCed") was that a sensor that _is being GCed_ must be deactivated if necessary. Fixes w3c#372.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246
Preview | Diff