-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitBook has accessibility isssues #192
Comments
Thanks for taking the time to look at this, Rhys. If you'd like to suggest some modifications to the CSS styling to address the colour contrast, that would be reasonably easy for me to incorporate. Changes to the header styles etc. would require some authoring changes up-stream from the creation of the GitBook materials, which I'll need to think about. Changes to the alt text for elements like the navigation would ideally be made in GitBook itself so that we don't have to patch the output manually after each generation. |
@ryceg, I've recently changed over to using mdBook instead of GitBook for producing the SMuFL specification. Would you be able to check out the current version and let me know if you still find similar accessibility issues? |
Hi @dspreadbury, I've taken a look at the update.
I'm afraid I'm not familiar enough with mdBook to be able to author a complete fix to all these issues, but I have made a pull request which at least addresses the contrast issues. Additionally, because you are serving SVGs, they do not render well in the dark mode; you may wish to style it with a background CSS of white, or use a css You also might like to look into implementing a GitHub Action to automate the process of building; https://github.com/peaceiris/actions-mdbook |
AxeTools returns several rather severe issues with the GitBook dark mode.
<h2>
elements instead of<h3>
elements.<nav>
element requires anaria-label
.alttext
.I'd be happy to create a separate issue for each of these, or have a crack at them if you're tied up with other stuff.
The text was updated successfully, but these errors were encountered: