Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change example 13. #15

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Change example 13. #15

wants to merge 1 commit into from

Conversation

r12a
Copy link
Contributor

@r12a r12a commented Mar 21, 2023

No description provided.

@r12a r12a requested a review from aphillips March 21, 2023 16:10
@r12a
Copy link
Contributor Author

r12a commented Mar 21, 2023

@xfq could you please enable Netlify for this repo (and as many others as you can).

Copy link
Contributor

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen the preview yet, but the change looks reasonable. Note the need to move the graphics and fix the links.

<td class="exampleChar">&#x627;&#x655;</td>
<td><code class="uname" translate="no">U+0627 ARABIC LETTER ALEF</code> + <code class="uname" translate="no">U+0655 ARABIC HAMZA BELOW</code></td>

<td class="exampleChar"><img src="https://r12a.github.io/c/Arabic/large/0625.png" alt="&#x065B;" style="height: 4rem; width: 4rem;"></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be sure to move the graphic to our repo and make the link relative?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i didn't do that pending approval for the approach, but we will need to do that before we can publish the doc to TR.

<td class="exampleChar">&#x6cc;&#x65a;</td>
<td><code class="uname" translate="no">U+06CC ARABIC LETTER FARSI YEH</code> + <code class="uname" translate="no">U+065A ARABIC VOWEL SIGN SMALL V ABOVE</code></td>
<td><strong>Not canonically equivalent</strong><br/>(differences that <em>remain</em> after Unicode Normalization) Many of these are linked to user perception of whether the vowel is part of the base letter (<em lang="ar-Latn" translate="no">ijam</em>) vs. separable (<em lang="ar-Latn" translate="no">tashkil</em> or <em lang="ar-Latn" translate="no">hamza</em>)</td>
<td class="exampleChar"><img src="https://r12a.github.io/c/Arabic/large/0681.png" alt="&#x065B;" style="height: 4rem; width: 4rem;"></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

<td><strong>Not canonically equivalent</strong><br/>(differences that <em>remain</em> after Unicode Normalization) Many of these are linked to user perception of whether the vowel is part of the base letter (<em lang="ar-Latn" translate="no">ijam</em>) vs. separable (<em lang="ar-Latn" translate="no">tashkil</em> or <em lang="ar-Latn" translate="no">hamza</em>)</td>
<td class="exampleChar"><img src="https://r12a.github.io/c/Arabic/large/0681.png" alt="&#x065B;" style="height: 4rem; width: 4rem;"></td>
<td><span class="codepoint" translate="no"><span class="uname">U+062D ARABIC LETTER HAH</span> + <span class="uname">U+0654 ARABIC HAMZA ABOVE</span></span> Preferred usage for Kashmiri to represent a consonant+vowel sequence <span class="ipa">hə</span>. The hamza represents the vowel sound.</td>
<td><span class="codepoint" translate="no"><span class="uname">U+0681 ARABIC LETTER HAH WITH HAMZA ABOVE</span></span> Used for Pashto consonant <span class="ipa">d͡z</span>. Can then be combined with other diacritics to indicate vowels.</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider entitizing the IPA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should apply a style to the ipa that puts /../ around the marked up item and probably ensure that we apply a webfont that can show all Latin characters, such as Noto Sans or SIL Gentium Plus.

<td><code class="uname" translate="no">U+0626 ARABIC LETTER YEH WITH HAMZA ABOVE</code></td>
<td class="exampleChar">&#x6cc;&#x654;</td>
<td><code class="uname" translate="no">U+06CC ARABIC LETTER FARSI YEH</code> + <code class="uname" translate="no">U+0654 ARABIC HAMZA ABOVE</code></td>
<td class="exampleChar"><img src="https://r12a.github.io/c/Arabic/large/065B.png" alt="&#x065B;" style="height: 4rem; width: 4rem;"></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file location

@xfq
Copy link
Member

xfq commented Mar 24, 2023

@xfq could you please enable Netlify for this repo (and as many others as you can).

Done. Feel free to push a commit to see the preview.

@aphillips
Copy link
Contributor

Nudging this PR. Can we address the comments and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants