-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up Changes appendix #521
Conversation
(Since the people most frequently mentioned aren't active working group members anymore, anyway.)
- Make sure there's a section for every chapter & appendix from SVG 1.1, and every one in SVG 2, and indicate which is which. - Put a list of all the major re-organizations in the "Editorial Changes" section at the top. - Added a few other missing changes, and corrected a few others. - Removed the testing links for the Linking chapter (still to be determined where/how best else to include this, but probably not here).
Also revert the removal of change-log history related to z-index (while still making the final outcome clear), and make clear that its removal was a deferment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much clearer. The (SVG 1.1 only / SVG 2 only) annotations are helpful; and the textual descriptions of chapter splits, merges and deletions are better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah these owners were kind of pointless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously better to be in the same order as the current document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better with the links to individual PRs and issue discussion.
Agree with your decision on z-index history.
Good work! I also agree with the decision on z-index. |
Tidying up the changes appendix. See commit messages for details.
Shouldn't really be any normative changes here, but I'd appreciate someone else taking a quick look to make sure I haven't broken anything.
I suspect that I'll find a few more missing changes as I go through the rest of the implementation review. But, it's still probably better to merge this sooner rather than later, so that other PRs (which all change the changes appendix, of course) can be rebased over top.
Other PRs will also need minor edits to add links to issues and PRs, as well as annotations to indicate that they are changes since the August CR, so that the tidy-up can last more than a few days!